Skip to content

[CALCITE-5607] Serialize return type during RelJson.toJson(RexNode node) serialization#3129

Closed
olivrlee wants to merge 5 commits intoapache:mainfrom
looker-open-source:reinterpret_tests
Closed

[CALCITE-5607] Serialize return type during RelJson.toJson(RexNode node) serialization#3129
olivrlee wants to merge 5 commits intoapache:mainfrom
looker-open-source:reinterpret_tests

Conversation

@olivrlee
Copy link
Contributor

@olivrlee olivrlee force-pushed the reinterpret_tests branch from 025383c to f43643b Compare March 23, 2023 21:13
tjbanghart referenced this pull request in looker-open-source/calcite Mar 28, 2023
…de node) (#28)

* Add tests to fix later

* Update test

* Add in type field to RelJson.toJson and update tests

* CALCITE-5607 / Serialize return type during RelJson.toJson(RexNode node)

* Update test comment

---------

Co-authored-by: Oliver Lee <oliverlee@google.com>
@olivrlee olivrlee closed this Apr 5, 2023
@olivrlee olivrlee reopened this Apr 18, 2023
@olivrlee olivrlee marked this pull request as ready for review April 18, 2023 22:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@julianhyde julianhyde force-pushed the main branch 2 times, most recently from 8a5cf83 to cf7f71b Compare June 8, 2023 21:21
@olivrlee olivrlee closed this Nov 9, 2023
@olivrlee olivrlee deleted the reinterpret_tests branch November 9, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants